Release 4.4. In Park feature "Allow Transfer" is not working

[Luciano Berardi]

Hi all,

I've just start working on call parking feature in the release 4.4 and I've
experienced problems with the "allow transfer". By searching on issue
tracker I found a similar bug that has been solved in release 4.6:
http://track.sipfoundry.org/browse/XX-10103 and applying it on 4.4 the
feature is working correctly.

Is it possible to backport this patch to 4.4? (commit:
2e849e409cc544d53ed4fee7d71b9ded0c2f75e7)

Thank you in advance

Regards
Luciano

[George Niculae]

On Fri, Jun 15, 2012 at 2:53 PM, Luciano Berardi

Post by Luciano Berardi
Hi all,
I've just start working on call parking feature in the release 4.4 and I've
experienced problems with the "allow transfer". By searching on issue
tracker I found a similar bug that has been solved in release
4.6: http://track.sipfoundry.org/browse/XX-10103 and applying it on 4.4 the
feature is working correctly.
Is it possible to backport this patch to 4.4?
(commit: 2e849e409cc544d53ed4fee7d71b9ded0c2f75e7)

The issue was introduced in 4.6, this is the code for 4.4 that doesn't
contain that issue:
https://github.com/dhubler/sipxecs/blob/release-4.4/sipXcallLib/src/cp/CpCall.cpp
Have you installed from rpms or built from sources? If later make sure
you're on release-4.4 branch

George

[Kumaran]

Hi Luciano,
I Just now checked call park feature which works fine(Allow
Transfer--After pressing 0 call Transferred back user,who parked the
call) in the latest build "4.4.0- 2012-04-13EDT09:33:36 ip-10-72-10-163"...
You checked in latest 4.4 build?If so can you please provide the
steps..I will try to reproduce....

Regards,
Kumaran T

Post by George Niculae
On Fri, Jun 15, 2012 at 2:53 PM, Luciano Berardi

Post by Luciano Berardi
Hi all,
I've just start working on call parking feature in the release 4.4 and I've
experienced problems with the "allow transfer". By searching on issue
tracker I found a similar bug that has been solved in release
4.6: http://track.sipfoundry.org/browse/XX-10103 and applying it on 4.4 the
feature is working correctly.
Is it possible to backport this patch to 4.4?
(commit: 2e849e409cc544d53ed4fee7d71b9ded0c2f75e7)

The issue was introduced in 4.6, this is the code for 4.4 that doesn't
https://github.com/dhubler/sipxecs/blob/release-4.4/sipXcallLib/src/cp/CpCall.cpp
Have you installed from rpms or built from sources? If later make sure
you're on release-4.4 branch
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[Michael Picher]

also, may not work with all phones... if you are on polycoms with 3.2.6
firmware with audiocodes gateways (5.8 & >) you should be good though.

On Fri, Jun 15, 2012 at 8:10 AM, Kumaran <

Post by Kumaran
Hi Luciano,
I Just now checked call park feature which works fine(Allow
Transfer--After pressing 0 call Transferred back user,who parked the
call) in the latest build "4.4.0- 2012-04-13EDT09:33:36
ip-10-72-10-163"...
You checked in latest 4.4 build?If so can you please provide the
steps..I will try to reproduce....
Regards,
Kumaran T

Post by George Niculae
On Fri, Jun 15, 2012 at 2:53 PM, Luciano Berardi

Post by Luciano Berardi
Hi all,
I've just start working on call parking feature in the release 4.4 and

I've

Post by George Niculae

Post by Luciano Berardi
experienced problems with the "allow transfer". By searching on issue
tracker I found a similar bug that has been solved in release
4.6: http://track.sipfoundry.org/browse/XX-10103 and applying it on

4.4 the

Post by George Niculae

Post by Luciano Berardi
feature is working correctly.
Is it possible to backport this patch to 4.4?
(commit: 2e849e409cc544d53ed4fee7d71b9ded0c2f75e7)

The issue was introduced in 4.6, this is the code for 4.4 that doesn't

https://github.com/dhubler/sipxecs/blob/release-4.4/sipXcallLib/src/cp/CpCall.cpp

Post by George Niculae
Have you installed from rpms or built from sources? If later make sure
you're on release-4.4 branch
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

--
Michael Picher, Director of Technical Services
eZuce, Inc.

300 Brickstone Square****

Suite 201****

Andover, MA. 01810
O.978-296-1005 X2015
M.207-956-0262
@mpicher <http://twitter.com/mpicher>
linkedin <http://www.linkedin.com/profile/view?id=35504760&trk=tab_pro>
www.ezuce.com

------------------------------------------------------------------------------------------------------------
There are 10 kinds of people in the world, those who understand binary and
those who don't.

[Luciano Berardi]

Hi,

thank you for your replies.
Currently my tests are performed in a Snom to Snom configuration. I've
rebuilt the system with commit 5b137b5216 of Date: Tue Jun 19 15:08:50.

The problem still persists. I'm having problem to identify where it exactly
crashes because in DEBUG mode everything works correctly, changing log
level from INFO on, it gives me just this warning message:

*"2012-06-20T08:09:31.455664Z":10:MP:WARNING:testpbx.labsip2ser.net:pid-25443:037FE700:sipxpark:"_REALTIME_LINUX_AUDIO_THREADS
was defined but application does not have ROOT priv."*

I'm continuing to investigate, any suggestion is really appreciated.

Regards
Luciano

Post by Michael Picher
also, may not work with all phones... if you are on polycoms with 3.2.6
firmware with audiocodes gateways (5.8 & >) you should be good though.
On Fri, Jun 15, 2012 at 8:10 AM, Kumaran <

Post by Kumaran
Hi Luciano,
I Just now checked call park feature which works fine(Allow
Transfer--After pressing 0 call Transferred back user,who parked the
call) in the latest build "4.4.0- 2012-04-13EDT09:33:36
ip-10-72-10-163"...
You checked in latest 4.4 build?If so can you please provide the
steps..I will try to reproduce....
Regards,
Kumaran T

Post by George Niculae
On Fri, Jun 15, 2012 at 2:53 PM, Luciano Berardi

Post by Luciano Berardi
Hi all,
I've just start working on call parking feature in the release 4.4 and

I've

Post by George Niculae

Post by Luciano Berardi
experienced problems with the "allow transfer". By searching on issue
tracker I found a similar bug that has been solved in release
4.6: http://track.sipfoundry.org/browse/XX-10103 and applying it on

4.4 the

Post by George Niculae

Post by Luciano Berardi
feature is working correctly.
Is it possible to backport this patch to 4.4?
(commit: 2e849e409cc544d53ed4fee7d71b9ded0c2f75e7)

The issue was introduced in 4.6, this is the code for 4.4 that doesn't

https://github.com/dhubler/sipxecs/blob/release-4.4/sipXcallLib/src/cp/CpCall.cpp

Post by George Niculae
Have you installed from rpms or built from sources? If later make sure
you're on release-4.4 branch
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

--
Michael Picher, Director of Technical Services
eZuce, Inc.
300 Brickstone Square****
Suite 201****
Andover, MA. 01810
O.978-296-1005 X2015
M.207-956-0262
@mpicher <http://twitter.com/mpicher>
linkedin <http://www.linkedin.com/profile/view?id=35504760&trk=tab_pro>
www.ezuce.com
------------------------------------------------------------------------------------------------------------
There are 10 kinds of people in the world, those who understand binary and
those who don't.
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[George Niculae]

On Wed, Jun 20, 2012 at 11:29 AM, Luciano Berardi

Post by Luciano Berardi
Hi,
thank you for your replies.
Currently my tests are performed in a Snom to Snom configuration. I've
rebuilt the system with commit 5b137b5216 of Date:   Tue Jun 19 15:08:50.
The problem still persists. I'm having problem to identify where it exactly
crashes because in DEBUG mode everything works correctly, changing log level
"2012-06-20T08:09:31.455664Z":10:MP:WARNING:testpbx.labsip2ser.net:pid-25443:037FE700:sipxpark:"_REALTIME_LINUX_AUDIO_THREADS
was defined but application does not have ROOT priv."
I'm continuing to investigate, any suggestion is really appreciated.

I'm confused, you said that backporting fix for
http://track.sipfoundry.org/browse/XX-10103 solved the issue, however
there is no way to backport that one as the code that introduced the
bug is not in there.
Have you installed from rpms or built from sources? If from sources
make sure you're on release-4.4 branch

George

[Luciano Berardi]

Hi,

sorry, maybe I didn't completely explained my tests.
After you suggestion to update my system version, I did it and today I was
running on a clean updated version without any change to the code.

Starting from this point I have done a deeper analysis of the call park
feature to allow transfer back to parker. I found that, using a different
log level than DEBUG, a segmentation fault happens. Indeed the sipXpark
process crashes.

from core dumps:

*Program received signal SIGSEGV, Segmentation fault.*
*[Switching to Thread 0x7fffcbfff700 (LWP 3741)]*
*CpCall::handleMessage (this=0x7fffbc006940, eventMessage=<value optimized
out>) at /home/admin/sipxecs/sipXcallLib/src/cp/CpCall.cpp:695*
*695 OsStatus res =
dtmfEvent->signal((eventData & 0xfffffff0));*


the "signal" method called on dtmfEvent needs a intptr_t parameter:

OsStatus OsQueuedEvent::signal(const *intptr_t* eventData)



So I partially applied the changes used in the patch
http://track.sipfoundry.org/browse/XX-10103 by only changing the type of
the "event" from int to intptr_t. Applying this changes everything works
fine.

Hope this better explains what I did and what I was asking for.
It could be the case to apply this changes to main tree.

Regards
Luciano

Post by George Niculae
On Wed, Jun 20, 2012 at 11:29 AM, Luciano Berardi

Post by Luciano Berardi
Hi,
thank you for your replies.
Currently my tests are performed in a Snom to Snom configuration. I've
rebuilt the system with commit 5b137b5216 of Date: Tue Jun 19 15:08:50.
The problem still persists. I'm having problem to identify where it

exactly

Post by Luciano Berardi
crashes because in DEBUG mode everything works correctly, changing log

level
pid-25443:037FE700:sipxpark:"_REALTIME_LINUX_AUDIO_THREADS

Post by Luciano Berardi
was defined but application does not have ROOT priv."
I'm continuing to investigate, any suggestion is really appreciated.

I'm confused, you said that backporting fix for
http://track.sipfoundry.org/browse/XX-10103 solved the issue, however
there is no way to backport that one as the code that introduced the
bug is not in there.
Have you installed from rpms or built from sources? If from sources
make sure you're on release-4.4 branch
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[George Niculae]

On Wed, Jun 20, 2012 at 6:44 PM, Luciano Berardi

Post by Luciano Berardi
Hi,
sorry, maybe I didn't completely explained my tests.
After you suggestion to update my system version, I did it and today I was
running on a clean updated version without any change to the code.
Starting from this point I have done a deeper analysis of the call park
feature to allow transfer back to parker. I found that, using a different
log level than DEBUG, a segmentation fault happens. Indeed the sipXpark
process crashes.
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffcbfff700 (LWP 3741)]
CpCall::handleMessage (this=0x7fffbc006940, eventMessage=<value optimized
out>) at /home/admin/sipxecs/sipXcallLib/src/cp/CpCall.cpp:695
695                                    OsStatus res =
dtmfEvent->signal((eventData & 0xfffffff0));
OsStatus OsQueuedEvent::signal(const intptr_t eventData)
So I partially applied the changes used in the
patch http://track.sipfoundry.org/browse/XX-10103 by only changing the type
of the "event" from int to intptr_t. Applying this changes everything works
fine.
Hope this better explains what I did and what I was asking for.
It could be the case to apply this changes to main tree.

Ah, ok, now it's clear - thanks for explanations. Would you mind
opening a JIRA for this?

George

[Luciano Berardi]

Hi,

Jira created http://track.sipfoundry.org/browse/XX-10213 . I attached the
patch to this mail. Let me know if something more is necessary.

Regards
Luciano

Post by George Niculae
On Wed, Jun 20, 2012 at 6:44 PM, Luciano Berardi

Post by Luciano Berardi
Hi,
sorry, maybe I didn't completely explained my tests.
After you suggestion to update my system version, I did it and today I

was

Post by Luciano Berardi
running on a clean updated version without any change to the code.
Starting from this point I have done a deeper analysis of the call park
feature to allow transfer back to parker. I found that, using a different
log level than DEBUG, a segmentation fault happens. Indeed the sipXpark
process crashes.
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffcbfff700 (LWP 3741)]
CpCall::handleMessage (this=0x7fffbc006940, eventMessage=<value optimized
out>) at /home/admin/sipxecs/sipXcallLib/src/cp/CpCall.cpp:695
695 OsStatus res =
dtmfEvent->signal((eventData & 0xfffffff0));
OsStatus OsQueuedEvent::signal(const intptr_t eventData)
So I partially applied the changes used in the
patch http://track.sipfoundry.org/browse/XX-10103 by only changing the

type

Post by Luciano Berardi
of the "event" from int to intptr_t. Applying this changes everything

works

Post by Luciano Berardi
fine.
Hope this better explains what I did and what I was asking for.
It could be the case to apply this changes to main tree.

Ah, ok, now it's clear - thanks for explanations. Would you mind
opening a JIRA for this?
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[George Niculae]

On Thu, Jun 21, 2012 at 11:34 AM, Luciano Berardi

Hi,
Jira created http://track.sipfoundry.org/browse/XX-10213 . I attached the
patch to this mail. Let me know if something more is necessary.

Thanks, I will take care of.

George

[Tony Graziano]

George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.

Does 4.5.x have the same behavior, or does anyone know yet?

Post by George Niculae
On Thu, Jun 21, 2012 at 11:34 AM, Luciano Berardi

Post by Luciano Berardi
Hi,
Jira created http://track.sipfoundry.org/browse/XX-10213 . I attached

the

Post by Luciano Berardi
patch to this mail. Let me know if something more is necessary.

Thanks, I will take care of.
George
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

--
~~~~~~~~~~~~~~~~~~
Tony Graziano, Manager
Telephone: [phone]
sip: ***@voice.myitdepartment.net
Fax: [phone]
~~~~~~~~~~~~~~~~~~
Linked-In Profile:
http://www.linkedin.com/pub/tony-graziano/14/4a6/7a4
Ask about our Internet Fax services!
~~~~~~~~~~~~~~~~~~

[George Niculae]

On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this

George

[Kumaran]

Post by George Niculae
On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this
George

George,
This issue is seen only in snom phones? Because I can't reproduce in
polycom....

Regards,
Kumaran T

Post by George Niculae
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[George Niculae]

On Thu, Jun 21, 2012 at 3:59 PM, Kumaran

Post by Kumaran

Post by George Niculae
On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this
George

George,
  This issue is seen only in snom phones? Because I can't reproduce in
polycom....

Don't think it relates to phone, have you set park on debug and
restarted service prior?

George

[Kumaran]

Post by George Niculae
On Thu, Jun 21, 2012 at 3:59 PM, Kumaran

Post by Kumaran

Post by George Niculae
On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this
George

George,
This issue is seen only in snom phones? Because I can't reproduce in
polycom....

Don't think it relates to phone, have you set park on debug and
restarted service prior?
George

I had set logging level to debug,info,alert,crt and restarted the
service each time..But I can't able to reproduce the issue....

Regards,
Kumaran T

[Domenico Chierico]

so what are the plans about this. I feel this patch quite clear and seems
to be formally correct to have the same type for all variables.

I'm not so deeper into it but don't seems to be dangerous

thanks
Domenico Chierico

On Thu, Jun 21, 2012 at 3:03 PM, Kumaran <

Post by Kumaran

Post by George Niculae
On Thu, Jun 21, 2012 at 3:59 PM, Kumaran

Post by Kumaran

Post by George Niculae
On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would

be

Post by George Niculae

Post by Kumaran

Post by George Niculae

Post by Tony Graziano
helpful to get a test rpm out to a few people (I volunteer) so it can

be

Post by George Niculae

Post by Kumaran

Post by George Niculae

Post by Tony Graziano
tested. If it doesn't further break things, it would be nice to see

in a

Post by George Niculae

Post by Kumaran

Post by George Niculae

Post by Tony Graziano
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this
George

George,
This issue is seen only in snom phones? Because I can't reproduce in
polycom....

Don't think it relates to phone, have you set park on debug and
restarted service prior?
George

I had set logging level to debug,info,alert,crt and restarted the
service each time..But I can't able to reproduce the issue....
Regards,
Kumaran T
_______________________________________________
sipx-users mailing list
List Archive: http://list.sipfoundry.org/archive/sipx-users/

[George Niculae]

On Fri, Jun 22, 2012 at 10:44 AM, Domenico Chierico

so what are the plans about this. I feel this patch quite clear and seems to
be formally correct to have the same type for all variables.
I'm not so deeper into it but don't seems to be dangerous

Committed - https://github.com/dhubler/sipxecs/commit/35fb37c21d386e80823981c66537c52329e879c3
please pull and retest.
Tony, there were some changes in tackLib component lately so the RPM I
can build for you to test would be on top of what is at this moment in
4.4 stage.

George

[Tony Graziano]

On Thu, Jun 21, 2012 at 8:59 AM, Kumaran <

Post by Kumaran

Post by George Niculae
On Thu, Jun 21, 2012 at 3:54 PM, Tony Graziano

Post by Tony Graziano
George -- If this is going to make it into a patch for 4.4, it would be
helpful to get a test rpm out to a few people (I volunteer) so it can be
tested. If it doesn't further break things, it would be nice to see in a
maintenance release for 4.4.
Does 4.5.x have the same behavior, or does anyone know yet?

Sure, I can do that, 4.5.x code was already changed to fix this
George

George,
This issue is seen only in snom phones? Because I can't reproduce in
polycom....
I am tracking my own issue where the timeout does not seem to work with an

unmanaged pstn gateway, so any changes to park might have the proper impact
on that.